Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: use better fatal message for staticValue1

Browse source 
So the position of the wrong assignment statement will be reported,
instead of using incorrect base.Pos one.

Notice while fixing issue #73823.

Change-Id: I53f240bf99d11b5f5082ee4ca0903d9f099881b6
Reviewed-on: https://go-review.googlesource.com/c/go/+/675495
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Mateusz Poliwczak <mpoliwczak34@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
Cuong Manh Le 2025-05-22 20:57:33 +07:00 • committed by Gopher Robot
parent 8587ba272e
commit 26338a7f69
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cmd/compile/internal/ir/expr.go
View file

@ -912,12 +912,12 @@ FindRHS:
break FindRHS break FindRHS
} }
} }
base.Fatalf("%v missing from LHS of %v", n, defn) base.FatalfAt(defn.Pos(), "%v missing from LHS of %v", n, defn)
default: default:
return nil return nil
} }
if rhs == nil { if rhs == nil {
base.Fatalf("RHS is nil: %v", defn) base.FatalfAt(defn.Pos(), "RHS is nil: %v", defn)
} }
if Reassigned(n) { if Reassigned(n) {

4
src/cmd/compile/internal/ir/reassignment.go
View file

@ -178,12 +178,12 @@ FindRHS:
break FindRHS break FindRHS
} }
} }
base.Fatalf("%v missing from LHS of %v", n, defn) base.FatalfAt(defn.Pos(), "%v missing from LHS of %v", n, defn)
default: default:
return nil return nil
} }
if rhs == nil { if rhs == nil {
base.Fatalf("RHS is nil: %v", defn) base.FatalfAt(defn.Pos(), "RHS is nil: %v", defn)
} }
if _, ok := ro.singleDef[n]; !ok { if _, ok := ro.singleDef[n]; !ok {