Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-11-02 17:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile/internal/ssa: eliminate string copies for calls to unique.Make

Browse source 
unique.Make always copies strings passed into it, so it's safe to not
copy byte slices converted to strings either. Handle this just like map
accesses with string(b) as keys.

This CL only handles unique.Make(string(b)), not nested cases like
unique.Make([2]string{string(b1), string(b2)}); this could be done in a
followup CL but the map lookup code in walk is sufficiently different
than the call handling code that I didn't attempt it. (SSA is much
easier).

Fixes #71926

Change-Id: Ic2f82f2f91963d563b4ddb1282bd49fc40da8b85
Reviewed-on: https://go-review.googlesource.com/c/go/+/672135
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Jake Bailey 2025-05-12 20:39:54 -07:00 • committed by Cherry Mui
parent d2db2372a2
commit 27ff0f249c
4 changed files with 72 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

35
src/cmd/compile/internal/ssa/rewritegeneric.go
View file

@ -30743,6 +30743,41 @@ func rewriteValuegeneric_OpStaticLECall(v *Value) bool {
v.AddArg4(typ_, map_, v0, mem)
return true
}
// match: (StaticLECall {f} [argsize] dict_ key:(SelectN [0] sbts:(StaticLECall {g} _ ptr len mem)) m:(SelectN [1] sbts))
// cond: isSameCall(f, "unique.Make[go.shape.string]") && isSameCall(g, "runtime.slicebytetostring") && key.Uses == 1 && sbts.Uses == 2 && resetCopy(m, mem) && clobber(sbts) && clobber(key)
// result: (StaticLECall {f} [argsize] dict_ (StringMake <typ.String> ptr len) mem)
for {
if len(v.Args) != 3 {
break
}
argsize := auxIntToInt32(v.AuxInt)
f := auxToCall(v.Aux)
_ = v.Args[2]
dict_ := v.Args[0]
key := v.Args[1]
if key.Op != OpSelectN || auxIntToInt64(key.AuxInt) != 0 {
break
}
sbts := key.Args[0]
if sbts.Op != OpStaticLECall || len(sbts.Args) != 4 {
break
}
g := auxToCall(sbts.Aux)
mem := sbts.Args[3]
ptr := sbts.Args[1]
len := sbts.Args[2]
m := v.Args[2]
if m.Op != OpSelectN || auxIntToInt64(m.AuxInt) != 1 || sbts != m.Args[0] || !(isSameCall(f, "unique.Make[go.shape.string]") && isSameCall(g, "runtime.slicebytetostring") && key.Uses == 1 && sbts.Uses == 2 && resetCopy(m, mem) && clobber(sbts) && clobber(key)) {
break
}
v.reset(OpStaticLECall)
v.AuxInt = int32ToAuxInt(argsize)
v.Aux = callToAux(f)
v0 := b.NewValue0(v.Pos, OpStringMake, typ.String)
v0.AddArg2(ptr, len)
v.AddArg3(dict_, v0, mem)
return true
}
return false
}
func rewriteValuegeneric_OpStore(v *Value) bool {