Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

encoding/json: add Path to UnmarshalTypeError

Browse source 
When parsing nested object, UnmarshalTypeError does not contain actual
path to nested field in original JSON.

This commit change Field to contain the full path to that field. One
can get the Field name by stripping all the leading path elements.

Fixes #22369

Change-Id: I6969cc08abe8387a351e3fb2944adfaa0dccad2a
Reviewed-on: https://go-review.googlesource.com/c/go/+/145218
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
LE Manh Cuong 2018-10-28 01:44:09 +07:00 • committed by Daniel Martí
parent 95d4e6158b
commit 29bc4f1258
2 changed files with 28 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/encoding/json/decode_test.go
View file

@ -45,6 +45,14 @@ type W struct {
S SS
}
type P struct {
PP PP
}
type PP struct {
T T
}
type SS string
func (*SS) UnmarshalJSON(data []byte) error {
@ -816,7 +824,7 @@ var unmarshalTests = []unmarshalTest{
err: &UnmarshalTypeError{
Value: "string",
Struct: "V",
Field: "F2",
Field: "V.F2",
Type: reflect.TypeOf(int32(0)),
Offset: 20,
},
@ -827,7 +835,7 @@ var unmarshalTests = []unmarshalTest{
err: &UnmarshalTypeError{
Value: "string",
Struct: "V",
Field: "F2",
Field: "V.F2",
Type: reflect.TypeOf(int32(0)),
Offset: 30,
},
@ -923,6 +931,18 @@ var unmarshalTests = []unmarshalTest{
ptr: new(MustNotUnmarshalText),
err: &UnmarshalTypeError{Value: "object", Type: reflect.TypeOf(&MustNotUnmarshalText{}), Offset: 1},
},
// #22369
{
in: `{"PP": {"T": {"Y": "bad-type"}}}`,
ptr: new(P),
err: &UnmarshalTypeError{
Value: "string",
Struct: "T",
Field: "PP.T.Y",
Type: reflect.TypeOf(int(0)),
Offset: 29,
},
},
}
func TestMarshal(t *testing.T) {