mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
[dev.ssa] cmd/compile/ssa: add nilcheckelim pass
The nilcheckelim pass eliminates unnecessary nil checks. The initial implementation removes redundant nil checks. See the comments in nilcheck.go for ideas for future improvements. The efficacy of the cse pass has a significant impact on this efficacy of this pass. There are 886 nil checks in the parts of the standard library that SSA can currently compile (~20%). This pass eliminates 75 (~8.5%) of them. As a data point, with a more aggressive but unsound cse pass that treats many more types as identical, this pass eliminates 115 (~13%) of the nil checks. Change-Id: I13e567a39f5f6909fc33434d55c17a7e3884a704 Reviewed-on: https://go-review.googlesource.com/11430 Reviewed-by: Alan Donovan <adonovan@google.com>
This commit is contained in:
parent
8c6abfeacb
commit
2a846d2bd3
4 changed files with 89 additions and 1 deletions
|
|
@ -52,6 +52,7 @@ var passes = [...]pass{
|
|||
{"copyelim", copyelim},
|
||||
{"opt", opt},
|
||||
{"generic cse", cse},
|
||||
{"nilcheckelim", nilcheckelim},
|
||||
{"generic deadcode", deadcode},
|
||||
{"dse", dse},
|
||||
{"fuse", fuse},
|
||||
|
|
@ -77,6 +78,12 @@ var passOrder = [...]constraint{
|
|||
// common-subexpression before dead-store elim, so that we recognize
|
||||
// when two address expressions are the same.
|
||||
{"generic cse", "dse"},
|
||||
// cse substantially improves nilcheckelim efficacy
|
||||
{"generic cse", "nilcheckelim"},
|
||||
// allow deadcode to clean up after nilcheckelim
|
||||
{"nilcheckelim", "generic deadcode"},
|
||||
// nilcheckelim generates sequences of plain basic blocks
|
||||
{"nilcheckelim", "fuse"},
|
||||
// don't layout blocks until critical edges have been removed
|
||||
{"critical", "layout"},
|
||||
// regalloc requires the removal of all critical edges
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue