Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

net: don't run TestDialListenerAddr in short mode on non-builders

Browse source 
It listens on all addresses, which users might not want.

Updates #18806 (follow-up to feedback from CL 45088)

Change-Id: I51de2d3fc3cd88a61eb3c63018c47aea920c0549
Reviewed-on: https://go-review.googlesource.com/45157
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
This commit is contained in:
Brad Fitzpatrick 2017-06-09 00:02:53 +00:00
parent bdc64183c8
commit 2c7043c273
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/net/dial_test.go
View file

@ -893,6 +893,9 @@ func TestCancelAfterDial(t *testing.T) {
// if the machine has halfway configured IPv6 such that it can bind on // if the machine has halfway configured IPv6 such that it can bind on
// "::" not connect back to that same address. // "::" not connect back to that same address.
func TestDialListenerAddr(t *testing.T) { func TestDialListenerAddr(t *testing.T) {
if testenv.Builder() == "" {
testenv.MustHaveExternalNetwork(t)
}
ln, err := Listen("tcp", ":0") ln, err := Listen("tcp", ":0")
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)