Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.ssa] cmd/internal/ssa: SSA cleanups

Browse source 
Mostly suggested by Alan.
Convert Const* ops to just one Const op.
Use more of go/types.
Get rid of typers, all types must be specified explicitly.

Change-Id: Id4758f2b887d8a6888e88a7e047d97af55e34b62
Reviewed-on: https://go-review.googlesource.com/8110
Reviewed-by: Alan Donovan <adonovan@google.com>
This commit is contained in:
Keith Randall 2015-03-26 10:49:03 -07:00
parent 7b96284295
commit 2c9b491e01
16 changed files with 269 additions and 172 deletions
Download patch file Download diff file Expand all files Collapse all files

55
src/cmd/internal/ssa/rewrite.go
View file

@ -28,43 +28,36 @@ func applyRewrite(f *Func, r func(*Value) bool) {
// Common functions called from rewriting rules
func is64BitInt(t Type) bool {
return typeIdentical(t, TypeInt64) ||
typeIdentical(t, TypeUint64) ||
(typeIdentical(t, TypeInt) && intSize == 8) ||
(typeIdentical(t, TypeUint) && intSize == 8) ||
(typeIdentical(t, TypeUintptr) && ptrSize == 8)
if b, ok := t.Underlying().(*types.Basic); ok {
switch b.Kind() {
case types.Int64, types.Uint64:
return true
}
}
return false
}
func is32BitInt(t Type) bool {
return typeIdentical(t, TypeInt32) ||
typeIdentical(t, TypeUint32) ||
(typeIdentical(t, TypeInt) && intSize == 4) ||
(typeIdentical(t, TypeUint) && intSize == 4) ||
(typeIdentical(t, TypeUintptr) && ptrSize == 4)
if b, ok := t.Underlying().(*types.Basic); ok {
switch b.Kind() {
case types.Int32, types.Uint32:
return true
}
}
return false
}
func isSigned(t Type) bool {
return typeIdentical(t, TypeInt) ||
typeIdentical(t, TypeInt8) ||
typeIdentical(t, TypeInt16) ||
typeIdentical(t, TypeInt32) ||
typeIdentical(t, TypeInt64)
if b, ok := t.Underlying().(*types.Basic); ok {
switch b.Kind() {
case types.Int8, types.Int16, types.Int32, types.Int64:
return true
}
}
return false
}
func typeSize(t Type) int {
switch t {
case TypeInt32, TypeUint32:
return 4
case TypeInt64, TypeUint64:
return 8
case TypeUintptr:
return ptrSize
case TypeInt, TypeUint:
return intSize
default:
if _, ok := t.(*types.Pointer); ok {
return ptrSize
}
panic("TODO: width of " + t.String())
}
var sizer types.Sizes = &types.StdSizes{int64(ptrSize), int64(ptrSize)} // TODO(khr): from config
func typeSize(t Type) int64 {
return sizer.Sizeof(t)
}