Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

net, runtime: skip flaky tests on OpenBSD

Browse source 
Flaky tests are a distraction and cover up real problems.

File bugs instead and mark them as flaky.

This moves the net/http flaky test flagging mechanism to internal/testenv.

Updates #15156
Updates #15157
Updates #15158

Change-Id: I0e561cd2a09c0dec369cd4ed93bc5a2b40233dfe
Reviewed-on: https://go-review.googlesource.com/21614
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Brad Fitzpatrick 2016-04-06 19:02:27 +00:00
parent f38f43d029
commit 2cefd12a1b
9 changed files with 31 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/context/context_test.go
View file

@ -6,6 +6,7 @@ package context
import (
"fmt"
"internal/testenv"
"math/rand"
"runtime"
"strings"
@ -258,6 +259,9 @@ func TestDeadline(t *testing.T) {
}
func TestTimeout(t *testing.T) {
if runtime.GOOS == "openbsd" {
testenv.SkipFlaky(t, 15158)
}
c, _ := WithTimeout(Background(), 100*time.Millisecond)
if got, prefix := fmt.Sprint(c), "context.Background.WithDeadline("; !strings.HasPrefix(got, prefix) {
t.Errorf("c.String() = %q want prefix %q", got, prefix)