Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: extract gc.eqtype as types.Identical

Browse source 
For symmetry with go/types.Identical.

Passes toolstash-check.

Change-Id: Id19c3956e44ed8e2d9f203d15824322cc5842d3d
Reviewed-on: https://go-review.googlesource.com/c/143180
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Matthew Dempsky 2018-10-18 15:24:50 -07:00
parent a440cc0d70
commit 2d58fbac2f
13 changed files with 161 additions and 155 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/cmd/compile/internal/gc/walk.go
View file

@ -1681,7 +1681,7 @@ func fncall(l *Node, rt *types.Type) bool {
if l.HasCall() || l.Op == OINDEXMAP {
return true
}
if eqtype(l.Type, rt) {
if types.Identical(l.Type, rt) {
return false
}
// There might be a conversion required, which might involve a runtime call.
@ -2023,7 +2023,7 @@ func walkprint(nn *Node, init *Nodes) *Node {
r := nod(OCALL, on, nil)
if params := on.Type.Params().FieldSlice(); len(params) > 0 {
t := params[0].Type
if !eqtype(t, n.Type) {
if !types.Identical(t, n.Type) {
n = nod(OCONV, n, nil)
n.Type = t
}
@ -2102,7 +2102,7 @@ func convas(n *Node, init *Nodes) *Node {
return n
}
if !eqtype(lt, rt) {
if !types.Identical(lt, rt) {
n.Right = assignconv(n.Right, lt, "assignment")
n.Right = walkexpr(n.Right, init)
}
@ -2575,7 +2575,7 @@ func mkcall1(fn *Node, t *types.Type, init *Nodes, args ...*Node) *Node {
}
func conv(n *Node, t *types.Type) *Node {
if eqtype(n.Type, t) {
if types.Identical(n.Type, t) {
return n
}
n = nod(OCONV, n, nil)
@ -2597,7 +2597,7 @@ func convnop(n *Node, t *types.Type) *Node {
// We cannot use conv, because we allow converting bool to uint8 here,
// which is forbidden in user code.
func byteindex(n *Node) *Node {
if eqtype(n.Type, types.Types[TUINT8]) {
if types.Identical(n.Type, types.Types[TUINT8]) {
return n
}
n = nod(OCONV, n, nil)
@ -3457,7 +3457,7 @@ func walkcompare(n *Node, init *Nodes) *Node {
func walkcompareInterface(n *Node, init *Nodes) *Node {
// ifaceeq(i1 any-1, i2 any-2) (ret bool);
if !eqtype(n.Left.Type, n.Right.Type) {
if !types.Identical(n.Left.Type, n.Right.Type) {
Fatalf("ifaceeq %v %v %v", n.Op, n.Left.Type, n.Right.Type)
}
var fn *Node