mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
cmd/compile: loop to ensure all autogenerated functions are compiled
I was wrong. There was a need to loop here. Fixes #24761 Change-Id: If13b3ab72febde930bdaebdddd1c05e0d0446020 Reviewed-on: https://go-review.googlesource.com/105615 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
parent
8f6ae33796
commit
2dfb423e6e
4 changed files with 43 additions and 9 deletions
|
|
@ -144,16 +144,17 @@ func dumpLinkerObj(bout *bio.Writer) {
|
|||
dumpimportstrings()
|
||||
dumpbasictypes()
|
||||
|
||||
// The first call to dumpsignats can generate functions,
|
||||
// Calls to dumpsignats can generate functions,
|
||||
// like method wrappers and hash and equality routines.
|
||||
compileFunctions()
|
||||
|
||||
// Process any new signats added during compilation.
|
||||
// No need to loop here; signats from compiling the generated
|
||||
// functions should not themselves generate new functions.
|
||||
// If they do, we'll know about it; the sanity check of
|
||||
// len(compilequeue) in gc.Main will fail.
|
||||
dumpsignats()
|
||||
// Compile any generated functions, process any new resulting types, repeat.
|
||||
// This can't loop forever, because there is no way to generate an infinite
|
||||
// number of types in a finite amount of code.
|
||||
// In the typical case, we loop 0 or 1 times.
|
||||
// It was not until issue 24761 that we found any code that required a loop at all.
|
||||
for len(compilequeue) > 0 {
|
||||
compileFunctions()
|
||||
dumpsignats()
|
||||
}
|
||||
|
||||
// Dump extra globals.
|
||||
tmp := externdcl
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue