Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-11-06 11:40:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

codereview: use cmd.communicate.

Browse source 
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4145046
This commit is contained in:
Yasuhiro Matsumoto 2011-02-08 22:30:06 -05:00 • committed by Russ Cox
parent 642c774081
commit 3108f3f4a0
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/codereview/codereview.py
View file

@ -1146,10 +1146,8 @@ def clpatch(ui, repo, clname, **opts):
except:
return "hgpatch: " + ExceptionDetail()
cmd.stdin.write(patch)
cmd.stdin.close()
out = cmd.stdout.read()
if cmd.wait() != 0 and not opts["ignore_hgpatch_failure"]:
out, err = cmd.communicate(patch)
if cmd.returncode != 0 and not opts["ignore_hgpatch_failure"]:
return "hgpatch failed"
cl.local = True
cl.files = out.strip().split()