Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-11-11 14:11:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/go: remove warning from module deprecation notice printing

Browse source 
Fixes #46294

Change-Id: I50023006dab83dee455f98a702ca1c72e61764ea
Reviewed-on: https://go-review.googlesource.com/c/go/+/321649
Trust: Jay Conrod <jayconrod@google.com>
Trust: Michael Matloob <matloob@golang.org>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
This commit is contained in:
Tim Heckman 2021-05-20 16:51:28 -07:00 • committed by Jay Conrod
parent 7e63c8b765
commit 3148694f60
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/go/internal/modget/get.go
View file

@ -1598,7 +1598,7 @@ func (r *resolver) checkPackageProblems(ctx context.Context, pkgPatterns []strin
// Report deprecations, then retractions. // Report deprecations, then retractions.
for _, mm := range deprecations { for _, mm := range deprecations {
if mm.message != "" { if mm.message != "" {
fmt.Fprintf(os.Stderr, "go: warning: module %s is deprecated: %s\n", mm.m.Path, mm.message) fmt.Fprintf(os.Stderr, "go: module %s is deprecated: %s\n", mm.m.Path, mm.message)
} }
} }
var retractPath string var retractPath string

8
src/cmd/go/testdata/script/mod_deprecate_message.txt vendored
View file

@ -1,26 +1,26 @@
# When there is a short single-line message, 'go get' should print it all. # When there is a short single-line message, 'go get' should print it all.
go get -d short go get -d short
stderr '^go: warning: module short is deprecated: short$' stderr '^go: module short is deprecated: short$'
go list -m -u -f '{{.Deprecated}}' short go list -m -u -f '{{.Deprecated}}' short
stdout '^short$' stdout '^short$'
# When there is a multi-line message, 'go get' should print the first line. # When there is a multi-line message, 'go get' should print the first line.
go get -d multiline go get -d multiline
stderr '^go: warning: module multiline is deprecated: first line$' stderr '^go: module multiline is deprecated: first line$'
! stderr 'second line' ! stderr 'second line'
go list -m -u -f '{{.Deprecated}}' multiline go list -m -u -f '{{.Deprecated}}' multiline
stdout '^first line\nsecond line.$' stdout '^first line\nsecond line.$'
# When there is a long message, 'go get' should print a placeholder. # When there is a long message, 'go get' should print a placeholder.
go get -d long go get -d long
stderr '^go: warning: module long is deprecated: \(message omitted: too long\)$' stderr '^go: module long is deprecated: \(message omitted: too long\)$'
go list -m -u -f '{{.Deprecated}}' long go list -m -u -f '{{.Deprecated}}' long
stdout '^aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa$' stdout '^aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa$'
# When a message contains unprintable chracters, 'go get' should say that # When a message contains unprintable chracters, 'go get' should say that
# without printing the message. # without printing the message.
go get -d unprintable go get -d unprintable
stderr '^go: warning: module unprintable is deprecated: \(message omitted: contains non-printable characters\)$' stderr '^go: module unprintable is deprecated: \(message omitted: contains non-printable characters\)$'
go list -m -u -f '{{.Deprecated}}' unprintable go list -m -u -f '{{.Deprecated}}' unprintable
stdout '^message contains ASCII BEL\x07$' stdout '^message contains ASCII BEL\x07$'

8
src/cmd/go/testdata/script/mod_get_deprecated.txt vendored
View file

@ -4,14 +4,14 @@ go get -d ./use/nothing
# 'go get pkg' should show a deprecation message for the module providing pkg. # 'go get pkg' should show a deprecation message for the module providing pkg.
go get -d example.com/deprecated/a go get -d example.com/deprecated/a
stderr '^go: warning: module example.com/deprecated/a is deprecated: in example.com/deprecated/a@v1.9.0$' stderr '^go: module example.com/deprecated/a is deprecated: in example.com/deprecated/a@v1.9.0$'
go get -d example.com/deprecated/a@v1.0.0 go get -d example.com/deprecated/a@v1.0.0
stderr '^go: warning: module example.com/deprecated/a is deprecated: in example.com/deprecated/a@v1.9.0$' stderr '^go: module example.com/deprecated/a is deprecated: in example.com/deprecated/a@v1.9.0$'
# 'go get pkg' should show a deprecation message for a module providing # 'go get pkg' should show a deprecation message for a module providing
# packages directly imported by pkg. # packages directly imported by pkg.
go get -d ./use/a go get -d ./use/a
stderr '^go: warning: module example.com/deprecated/a is deprecated: in example.com/deprecated/a@v1.9.0$' stderr '^go: module example.com/deprecated/a is deprecated: in example.com/deprecated/a@v1.9.0$'
# 'go get pkg' may show a deprecation message for an indirectly required module # 'go get pkg' may show a deprecation message for an indirectly required module
# if it provides a package named on the command line. # if it provides a package named on the command line.
@ -20,7 +20,7 @@ go get -d ./use/b
go get -d local/use go get -d local/use
! stderr 'module.*is deprecated' ! stderr 'module.*is deprecated'
go get -d example.com/deprecated/b go get -d example.com/deprecated/b
stderr '^go: warning: module example.com/deprecated/b is deprecated: in example.com/deprecated/b@v1.9.0$' stderr '^go: module example.com/deprecated/b is deprecated: in example.com/deprecated/b@v1.9.0$'
# 'go get pkg' does not show a deprecation message for a module providing a # 'go get pkg' does not show a deprecation message for a module providing a
# directly imported package if the module is no longer deprecated in its # directly imported package if the module is no longer deprecated in its