Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: fix nmspinning comparison

Browse source 
nmspinning has a value range of [0, 2^31-1].  Update the comment to
indicate this and fix the comparison so it's not always false.

Fixes #11280

Change-Id: Iedaf0654dcba5e2c800645f26b26a1a781ea1991
Reviewed-on: https://go-review.googlesource.com/13877
Reviewed-by: Minux Ma <minux@golang.org>
This commit is contained in:
Todd Neal 2015-08-24 19:11:35 -05:00
parent 24be0997a2
commit 3efe36d4c4
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/runtime/proc1.go
View file

@ -1538,7 +1538,7 @@ func resetspinning() {
if _g_.m.spinning { if _g_.m.spinning {
_g_.m.spinning = false _g_.m.spinning = false
nmspinning = xadd(&sched.nmspinning, -1) nmspinning = xadd(&sched.nmspinning, -1)
if nmspinning < 0 { if int32(nmspinning) < 0 {
throw("findrunnable: negative nmspinning") throw("findrunnable: negative nmspinning")
} }
} else { } else {

2
src/runtime/runtime2.go
View file

@ -429,7 +429,7 @@ type schedt struct {
pidle puintptr // idle p's pidle puintptr // idle p's
npidle uint32 npidle uint32
nmspinning uint32 nmspinning uint32 // limited to [0, 2^31-1]
// Global runnable queue. // Global runnable queue.
runqhead guintptr runqhead guintptr