Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

bytes, os/exec, strings: fix a few BUG comments

Browse source 
Regular expression noteMarker requires the definition of a (who) section
when reading note from a sequence of comments.

Change-Id: I9635de9b86f00d20ec108097fee4d4a8f76237b2
Reviewed-on: https://go-review.googlesource.com/1952
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
areski 2014-12-22 18:16:15 +01:00 • committed by Russ Cox
parent 9c0b145e4c
commit 3f12d27133
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/bytes/bytes.go
View file

@ -443,7 +443,7 @@ func isSeparator(r rune) bool {
// Title returns a copy of s with all Unicode letters that begin words // Title returns a copy of s with all Unicode letters that begin words
// mapped to their title case. // mapped to their title case.
// //
// BUG: The rule Title uses for word boundaries does not handle Unicode punctuation properly. // BUG(rsc): The rule Title uses for word boundaries does not handle Unicode punctuation properly.
func Title(s []byte) []byte { func Title(s []byte) []byte {
// Use a closure here to remember state. // Use a closure here to remember state.
// Hackish but effective. Depends on Map scanning in order and calling // Hackish but effective. Depends on Map scanning in order and calling

2
src/os/exec/exec.go
View file

@ -80,7 +80,7 @@ type Cmd struct {
// new process. It does not include standard input, standard output, or // new process. It does not include standard input, standard output, or
// standard error. If non-nil, entry i becomes file descriptor 3+i. // standard error. If non-nil, entry i becomes file descriptor 3+i.
// //
// BUG: on OS X 10.6, child processes may sometimes inherit unwanted fds. // BUG(rsc): On OS X 10.6, child processes may sometimes inherit unwanted fds.
// http://golang.org/issue/2603 // http://golang.org/issue/2603
ExtraFiles []*os.File ExtraFiles []*os.File

2
src/strings/strings.go
View file

@ -520,7 +520,7 @@ func isSeparator(r rune) bool {
// Title returns a copy of the string s with all Unicode letters that begin words // Title returns a copy of the string s with all Unicode letters that begin words
// mapped to their title case. // mapped to their title case.
// //
// BUG: The rule Title uses for word boundaries does not handle Unicode punctuation properly. // BUG(rsc): The rule Title uses for word boundaries does not handle Unicode punctuation properly.
func Title(s string) string { func Title(s string) string {
// Use a closure here to remember state. // Use a closure here to remember state.
// Hackish but effective. Depends on Map scanning in order and calling // Hackish but effective. Depends on Map scanning in order and calling