Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

net: enable test for runtime.PollDesc leak

Browse source 
Update #5219.

R=golang-dev, dvyukov, r
CC=golang-dev
https://golang.org/cl/8602047
This commit is contained in:
Mikio Hara 2013-04-20 09:04:20 +09:00
parent 10cdb92000
commit 41451dd92b
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/pkg/net/dial_test.go
View file

@ -331,14 +331,13 @@ func numFD() int {
panic("numFDs not implemented on " + runtime.GOOS)
}
var testPoller = flag.Bool("poller", false, "platform supports runtime-integrated poller")
// Assert that a failed Dial attempt does not leak
// runtime.PollDesc structures
func TestDialPollDescLeak(t *testing.T) {
// remove once CL 8318044 is submitted
t.Skip("Test skipped pending submission of CL 8318044")
if testing.Short() {
t.Skip("skipping PollDesc leak test in -short mode")
func TestDialFailPDLeak(t *testing.T) {
if !*testPoller {
t.Skip("test disabled; use -poller to enable")
}
const loops = 10
@ -352,10 +351,11 @@ func TestDialPollDescLeak(t *testing.T) {
old = new
return delta
}
d := &Dialer{Timeout: time.Nanosecond} // don't bother TCP with handshaking
failcount := 0
for i := 0; i < loops; i++ {
for i := 0; i < count; i++ {
conn, err := Dial("tcp", "127.0.0.1:1")
conn, err := d.Dial("tcp", "127.0.0.1:1")
if err == nil {
t.Error("dial should not succeed")
conn.Close()
@ -367,7 +367,7 @@ func TestDialPollDescLeak(t *testing.T) {
}
// there are always some allocations on the first loop
if failcount > 3 {
t.Error("net.Dial leaked memory")
t.Error("detected possible memory leak in runtime")
t.FailNow()
}
}