Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: omit racefuncentry/exit when they are not needed

Browse source 
When compiling with -race, we insert calls to racefuncentry,
into every function. Add a rule that removes them in leaf functions,
without instrumented loads/stores.
Shaves ~30kb from "-race" version of go tool:

file difference:
go_old 15626192
go_new 15597520 [-28672 bytes]

section differences:
global text (code) = -24513 bytes (-0.358598%)
read-only data = -5849 bytes (-0.167064%)
Total difference -30362 bytes (-0.097928%)

Fixes #24662

Change-Id: Ia63bf1827f4cf2c25e3e28dcd097c150994ade0a
Reviewed-on: https://go-review.googlesource.com/121235
Run-TryBot: Ilya Tocar <ilya.tocar@intel.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Ilya Tocar 2018-06-27 11:40:24 -05:00
parent f76eaeb2c8
commit 4201c2077e
6 changed files with 51 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/cmd/compile/internal/ssa/rewritegeneric.go
View file

@ -27595,6 +27595,20 @@ func rewriteValuegeneric_OpStaticCall_0(v *Value) bool {
v.AddArg(mem)
return true
}
// match: (StaticCall {sym} x)
// cond: needRaceCleanup(sym,v)
// result: x
for {
sym := v.Aux
x := v.Args[0]
if !(needRaceCleanup(sym, v)) {
break
}
v.reset(OpCopy)
v.Type = x.Type
v.AddArg(x)
return true
}
return false
}
func rewriteValuegeneric_OpStore_0(v *Value) bool {