Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: fix choice of phi building algorithm

Browse source 
The algorithm for placing a phi nodes in small functions now
unreachable. This patch fix that.

Change-Id: I253d745b414fa12ee0719459c28e78a69c6861ae
Reviewed-on: https://go-review.googlesource.com/30106
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Andrew Pogrebnoy 2016-10-04 02:39:33 +03:00 • committed by Keith Randall
parent 94589054d3
commit 433be563b6
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/compile/internal/gc/phi.go
View file

@ -28,7 +28,7 @@ const debugPhi = false
// of the appropriate phi or definition. // of the appropriate phi or definition.
// TODO: make this part of cmd/compile/internal/ssa somehow? // TODO: make this part of cmd/compile/internal/ssa somehow?
func (s *state) insertPhis() { func (s *state) insertPhis() {
if len(s.f.Blocks) <= smallBlocks && false { if len(s.f.Blocks) <= smallBlocks {
sps := simplePhiState{s: s, f: s.f, defvars: s.defvars} sps := simplePhiState{s: s, f: s.f, defvars: s.defvars}
sps.insertPhis() sps.insertPhis()
return return