Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

crypto/ed25519: skip allocations test on -noopt builder

Browse source 
Without optimizations, there will be unexpected allocations.

Change-Id: I90dc2636279b7fda7689eabc763251c4cdd25874
Reviewed-on: https://go-review.googlesource.com/c/go/+/317370
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
This commit is contained in:
Filippo Valsorda 2021-05-05 21:32:04 -04:00
parent cf73f1a8e4
commit 43c390a1fa
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/crypto/ed25519/ed25519_test.go
View file

@ -186,6 +186,9 @@ func TestMalleability(t *testing.T) {
} }
func TestAllocations(t *testing.T) { func TestAllocations(t *testing.T) {
if strings.HasSuffix(os.Getenv("GO_BUILDER_NAME"), "-noopt") {
t.Skip("skipping allocations test without relevant optimizations")
}
if allocs := testing.AllocsPerRun(100, func() { if allocs := testing.AllocsPerRun(100, func() {
seed := make([]byte, SeedSize) seed := make([]byte, SeedSize)
message := []byte("Hello, world!") message := []byte("Hello, world!")

5
src/crypto/ed25519/internal/edwards25519/edwards25519_test.go
View file

@ -7,7 +7,9 @@ package edwards25519
import ( import (
"crypto/ed25519/internal/edwards25519/field" "crypto/ed25519/internal/edwards25519/field"
"encoding/hex" "encoding/hex"
"os"
"reflect" "reflect"
"strings"
"testing" "testing"
) )
@ -279,6 +281,9 @@ func TestNonCanonicalPoints(t *testing.T) {
var testAllocationsSink byte var testAllocationsSink byte
func TestAllocations(t *testing.T) { func TestAllocations(t *testing.T) {
if strings.HasSuffix(os.Getenv("GO_BUILDER_NAME"), "-noopt") {
t.Skip("skipping allocations test without relevant optimizations")
}
if allocs := testing.AllocsPerRun(100, func() { if allocs := testing.AllocsPerRun(100, func() {
p := NewIdentityPoint() p := NewIdentityPoint()
p.Add(p, NewGeneratorPoint()) p.Add(p, NewGeneratorPoint())