mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
runtime: don't try to free OS-created signal stacks
Android's libc creates a signal stack for every thread it creates. In Go, minitSignalStack picks up this existing signal stack and puts it in m.gsignal.stack. However, if we later try to exit a thread (because a locked goroutine is exiting), we'll attempt to stackfree this libc-allocated signal stack and panic. Fix this by clearing gsignal.stack when we unminitSignals in such a situation. This should fix the Android build, which is currently broken. Change-Id: Ieea8d72ef063d22741c54c9daddd8bb84926a488 Reviewed-on: https://go-review.googlesource.com/70130 Reviewed-by: David Crawshaw <crawshaw@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
parent
a3e013b082
commit
44d9e96da9
2 changed files with 11 additions and 1 deletions
|
|
@ -744,6 +744,10 @@ func unminitSignals() {
|
|||
if getg().m.newSigstack {
|
||||
st := stackt{ss_flags: _SS_DISABLE}
|
||||
sigaltstack(&st, nil)
|
||||
} else {
|
||||
// We got the signal stack from someone else. Clear it
|
||||
// so we don't get confused.
|
||||
getg().m.gsignal.stack = stack{}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue