Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.regabi] add FatalfAt and fix Fatalf docs

Browse source 
I've wanted a FatalfAt function for a while, but under the old "-l"
suffix naming convention it would have been called "Fatalfl", which is
just atrocious.

Change-Id: If87f692ecdff478769426d4b054ac396e5c1e42e
Reviewed-on: https://go-review.googlesource.com/c/go/+/273013
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
Matthew Dempsky 2020-11-24 15:52:13 -08:00
parent 484449c641
commit 4a6b4fd139
1 changed files with 21 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/cmd/compile/internal/gc/print.go
View file

@ -177,23 +177,39 @@ func Warnl(pos src.XPos, format string, args ...interface{}) {
} }
} }
// Fatal reports a fatal error - an internal problem - at the current line and exits. // Fatalf reports a fatal error - an internal problem - at the current line and exits.
// If other errors have already been printed, then Fatal just quietly exits. // If other errors have already been printed, then Fatalf just quietly exits.
// (The internal problem may have been caused by incomplete information // (The internal problem may have been caused by incomplete information
// after the already-reported errors, so best to let users fix those and // after the already-reported errors, so best to let users fix those and
// try again without being bothered about a spurious internal error.) // try again without being bothered about a spurious internal error.)
// //
// But if no errors have been printed, or if -d panic has been specified, // But if no errors have been printed, or if -d panic has been specified,
// Fatal prints the error as an "internal compiler error". In a released build, // Fatalf prints the error as an "internal compiler error". In a released build,
// it prints an error asking to file a bug report. In development builds, it // it prints an error asking to file a bug report. In development builds, it
// prints a stack trace. // prints a stack trace.
// //
// If -h has been specified, Fatal panics to force the usual runtime info dump. // If -h has been specified, Fatalf panics to force the usual runtime info dump.
func Fatalf(format string, args ...interface{}) { func Fatalf(format string, args ...interface{}) {
FatalfAt(lineno, format, args...)
}
// FatalfAt reports a fatal error - an internal problem - at pos and exits.
// If other errors have already been printed, then FatalfAt just quietly exits.
// (The internal problem may have been caused by incomplete information
// after the already-reported errors, so best to let users fix those and
// try again without being bothered about a spurious internal error.)
//
// But if no errors have been printed, or if -d panic has been specified,
// FatalfAt prints the error as an "internal compiler error". In a released build,
// it prints an error asking to file a bug report. In development builds, it
// prints a stack trace.
//
// If -h has been specified, FatalfAt panics to force the usual runtime info dump.
func FatalfAt(pos src.XPos, format string, args ...interface{}) {
flusherrors() flusherrors()
if Debug_panic != 0 || numErrors == 0 { if Debug_panic != 0 || numErrors == 0 {
fmt.Printf("%v: internal compiler error: ", linestr(lineno)) fmt.Printf("%v: internal compiler error: ", linestr(pos))
fmt.Printf(format, args...) fmt.Printf(format, args...)
fmt.Printf("\n") fmt.Printf("\n")