Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/internal/objabi: shrink SymType down to a uint8

Browse source 
Now that it only takes small values.

Change-Id: I08086d392529d8775b470d65afc2475f8d0e7f4a
Reviewed-on: https://go-review.googlesource.com/42030
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Michael Hudson-Doyle 2017-04-28 08:07:56 +12:00
parent d2a9545178
commit 4aca8b00ff
4 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/internal/obj/objfile.go
View file

@ -283,7 +283,7 @@ func (w *objWriter) writeSym(s *LSym) {
} }
w.wr.WriteByte(symPrefix) w.wr.WriteByte(symPrefix)
w.writeInt(int64(s.Type)) w.wr.WriteByte(byte(s.Type))
w.writeRefIndex(s) w.writeRefIndex(s)
flags := int64(0) flags := int64(0)
if s.DuplicateOK() { if s.DuplicateOK() {

2
src/cmd/internal/objabi/symkind.go
View file

@ -31,7 +31,7 @@
package objabi package objabi
// A SymKind describes the kind of memory represented by a symbol. // A SymKind describes the kind of memory represented by a symbol.
type SymKind int16 type SymKind uint8
// Defined SymKind values. // Defined SymKind values.
// //

2
src/cmd/internal/objabi/symkind_string.go
View file

@ -9,7 +9,7 @@ const _SymKind_name = "SxxxSTEXTSRODATASNOPTRDATASDATASBSSSNOPTRBSSSTLSBSSSDWARF
var _SymKind_index = [...]uint8{0, 4, 9, 16, 26, 31, 35, 44, 51, 61} var _SymKind_index = [...]uint8{0, 4, 9, 16, 26, 31, 35, 44, 51, 61}
func (i SymKind) String() string { func (i SymKind) String() string {
if i < 0 || i >= SymKind(len(_SymKind_index)-1) { if i >= SymKind(len(_SymKind_index)-1) {
return fmt.Sprintf("SymKind(%d)", i) return fmt.Sprintf("SymKind(%d)", i)
} }
return _SymKind_name[_SymKind_index[i]:_SymKind_index[i+1]] return _SymKind_name[_SymKind_index[i]:_SymKind_index[i+1]]

9
src/cmd/link/internal/ld/objfile.go
View file

@ -155,10 +155,15 @@ func (r *objReader) readSlices() {
const symPrefix = 0xfe const symPrefix = 0xfe
func (r *objReader) readSym() { func (r *objReader) readSym() {
if c, err := r.rd.ReadByte(); c != symPrefix || err != nil { var c byte
var err error
if c, err = r.rd.ReadByte(); c != symPrefix || err != nil {
log.Fatalln("readSym out of sync") log.Fatalln("readSym out of sync")
} }
t := abiSymKindToSymKind[r.readInt()] if c, err = r.rd.ReadByte(); err != nil {
log.Fatalln("error reading input: ", err)
}
t := abiSymKindToSymKind[c]
s := r.readSymIndex() s := r.readSymIndex()
flags := r.readInt() flags := r.readInt()
dupok := flags&1 != 0 dupok := flags&1 != 0