cmd/compile, runtime: use R20, R21 in ARM64's Duff's devices

Currently we use R16 and R17 for ARM64's Duff's devices.
According to ARM64 ABI, R16 and R17 can be used by the (external)
linker as scratch registers in trampolines. So don't use these
registers to pass information across functions.

It seems unlikely that calling Duff's devices would need a
trampoline in normal cases. But it could happen if the call
target is out of the 128 MB direct jump limit.

The choice of R20 and R21 is kind of arbitrary. The register
allocator allocates from low-numbered registers. High numbered
registers are chosen so it is unlikely to hold a live value and
forces a spill.

Fixes #32773.

Change-Id: Id22d555b5afeadd4efcf62797d1580d641c39218
Reviewed-on: https://go-review.googlesource.com/c/go/+/183842
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Cherry Zhang 2019-06-25 14:48:04 -04:00
parent 24f7d89a73
commit 4ea7aa7cf3
7 changed files with 220 additions and 220 deletions

View file

@ -18668,9 +18668,9 @@ var opcodeTable = [...]opInfo{
faultOnNilArg0: true,
reg: regInfo{
inputs: []inputInfo{
{0, 65536}, // R16
{0, 1048576}, // R20
},
clobbers: 536936448, // R16 R30
clobbers: 537919488, // R20 R30
},
},
{
@ -18694,10 +18694,10 @@ var opcodeTable = [...]opInfo{
faultOnNilArg1: true,
reg: regInfo{
inputs: []inputInfo{
{0, 131072}, // R17
{1, 65536}, // R16
{0, 2097152}, // R21
{1, 1048576}, // R20
},
clobbers: 604176384, // R16 R17 R26 R30
clobbers: 607125504, // R20 R21 R26 R30
},
},
{