Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

reflect,doc: use "the" instead of "a" in IsZero docs

Browse source 
There is a subtle distinction between a value
*being* the zero value vs being *equal to* the zero value.
This was discussed at length in #31450.

Using "a zero value" in the docs suggests that there may
be more than zero value. That is possible on the "equal to
zero value" reading, but not the "is zero" reading that we
selected for the semantics of IsZero.

This change attempts to prevent any confusion on this front by
switching to "the zero value" in the documentation.

And while we're here, eliminate a double-space.
(Darn macbook keyboards.)

Change-Id: Iaa02ba297438793f5a90be9919a4d53baef92f8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/182617
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Josh Bleecher Snyder 2019-06-17 12:57:40 -07:00
parent bc27b64dba
commit 52572afa20
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
doc/go1.13.html
View file

@ -292,11 +292,11 @@ TODO
<dl id="reflect"><dt><a href="/pkg/reflect/">reflect</a></dt> <dl id="reflect"><dt><a href="/pkg/reflect/">reflect</a></dt>
<dd> <dd>
<p><!-- CL 171337 --> <p><!-- CL 171337 -->
The new <a href="/pkg/reflect/#Value.IsZero"><code>Value.IsZero</code></a> method reports whether a <code>Value</code> is a zero value for its type. The new <a href="/pkg/reflect/#Value.IsZero"><code>Value.IsZero</code></a> method reports whether a <code>Value</code> is the zero value for its type.
</p> </p>
<p><!-- CL 174531 --> <p><!-- CL 174531 -->
The <a href="/pkg/reflect/#MakeFunc"><code>MakeFunc</code></a> function now allows assignment conversions on returned values, instead of requiring exact type match. This is particularly useful when the type being returned is an interface type, but the value actually returned is a concrete value implementing that type. The <a href="/pkg/reflect/#MakeFunc"><code>MakeFunc</code></a> function now allows assignment conversions on returned values, instead of requiring exact type match. This is particularly useful when the type being returned is an interface type, but the value actually returned is a concrete value implementing that type.
</p> </p>
</dl><!-- reflect --> </dl><!-- reflect -->

2
src/reflect/value.go
View file

@ -1076,7 +1076,7 @@ func (v Value) IsValid() bool {
return v.flag != 0 return v.flag != 0
} }
// IsZero reports whether v is a zero value for its type. // IsZero reports whether v is the zero value for its type.
// It panics if the argument is invalid. // It panics if the argument is invalid.
func (v Value) IsZero() bool { func (v Value) IsZero() bool {
switch v.kind() { switch v.kind() {