Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-06-27 03:11:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

net/http: disable some flaky HTTP/3 tests

Browse source 
TestClientCallsCloseOnlyOnce and TestServerNoReadTimeout are flaky for
HTTP/3. Disable them for now.

Other HTTP/3 tests still have some flakes, but seems to be in line with
HTTP/1 and HTTP/2 tests.

For #78737

Change-Id: I94f5c62daec80ba89f311d996cbcc5d06a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/772720
Auto-Submit: Nicholas Husin <nsh@golang.org>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <husin@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
This commit is contained in:
Nicholas S. Husin 2026-04-30 17:30:23 -04:00 • committed by Gopher Robot
parent 23eac3d12b
commit 5732f4b76a
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/net/http/client_test.go
View file

@ -2222,7 +2222,10 @@ func TestClientPopulatesNilResponseBody(t *testing.T) {
}
// Issue 40382: Client calls Close multiple times on Request.Body.
func TestClientCallsCloseOnlyOnce(t *testing.T) { run(t, testClientCallsCloseOnlyOnce) }
func TestClientCallsCloseOnlyOnce(t *testing.T) {
// Flaky on HTTP/3.
run(t, testClientCallsCloseOnlyOnce, http3SkippedMode)
}
func testClientCallsCloseOnlyOnce(t *testing.T, mode testMode) {
cst := newClientServerTest(t, mode, HandlerFunc(func(w ResponseWriter, r *Request) {
w.WriteHeader(StatusNoContent)

5
src/net/http/serve_test.go
View file

@ -856,7 +856,10 @@ func testServerReadTimeout(t *testing.T, mode testMode) {
}
}
func TestServerNoReadTimeout(t *testing.T) { run(t, testServerNoReadTimeout) }
func TestServerNoReadTimeout(t *testing.T) {
// Flaky on HTTP/3.
run(t, testServerNoReadTimeout, http3SkippedMode)
}
func testServerNoReadTimeout(t *testing.T, mode testMode) {
reqBody := "Hello, Gophers!"
resBody := "Hi, Gophers!"