mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
cmd/compile: run escape analysis after method wrapper generation
Also modified test/run.go to ignore messages prefixed <autogenerated> because those cannot be described with "// ERROR ...", and backed out patch from issue #9537 because it is no longer necessary. The reasons described in the 9537 discussion for why escape analysis cannot run late no longer hold, happily. Fixes #11053. Change-Id: Icb14eccdf2e8cde3d0f8fb8a216b765400a96385 Reviewed-on: https://go-review.googlesource.com/11088 Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: David Chase <drchase@google.com>
This commit is contained in:
parent
6428a8b437
commit
5be61b18d4
8 changed files with 80 additions and 17 deletions
51
test/fixedbugs/issue11053.dir/p_test.go
Normal file
51
test/fixedbugs/issue11053.dir/p_test.go
Normal file
|
|
@ -0,0 +1,51 @@
|
|||
// Copyright 2015 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"p"
|
||||
)
|
||||
|
||||
type I interface {
|
||||
Add(out *P)
|
||||
}
|
||||
|
||||
type P struct {
|
||||
V *int32
|
||||
}
|
||||
|
||||
type T struct{}
|
||||
|
||||
var x int32 = 42
|
||||
|
||||
func Int32x(i int32) *int32 {
|
||||
return &i
|
||||
}
|
||||
|
||||
func (T) Add(out *P) {
|
||||
out.V = p.Int32(x) // inlined, p.i.2 moved to heap
|
||||
}
|
||||
|
||||
var PP P
|
||||
var out *P = &PP
|
||||
|
||||
func F(s I) interface{} {
|
||||
s.Add(out) // not inlined.
|
||||
return out
|
||||
}
|
||||
|
||||
var s T
|
||||
|
||||
func main() {
|
||||
println("Starting")
|
||||
fmt.Sprint(new(int32))
|
||||
resp := F(s).(*P)
|
||||
println("Before, *resp.V=", *resp.V) // Trashes *resp.V in process of printing.
|
||||
println("After, *resp.V=", *resp.V)
|
||||
if got, want := *resp.V, int32(42); got != want {
|
||||
fmt.Printf("FAIL, got %v, want %v", got, want)
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue