Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

net/http: replace os.MkdirTemp with T.TempDir

Browse source 
Updates: #45402
Change-Id: Ia61f422d058bf57fc3688abc25597d6cc1692c51
Reviewed-on: https://go-review.googlesource.com/c/go/+/307653
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dave Cheney <dave@cheney.net>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
This commit is contained in:
ianwoolf 2021-04-07 13:42:22 +08:00 • committed by Emmanuel Odeke
parent 4bbe046aad
commit 5d5f779db4
2 changed files with 3 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/net/http/filetransport_test.go
View file

@ -23,12 +23,10 @@ func checker(t *testing.T) func(string, error) {
func TestFileTransport(t *testing.T) { func TestFileTransport(t *testing.T) {
check := checker(t) check := checker(t)
dname, err := os.MkdirTemp("", "") dname := t.TempDir()
check("TempDir", err)
fname := filepath.Join(dname, "foo.txt") fname := filepath.Join(dname, "foo.txt")
err = os.WriteFile(fname, []byte("Bar"), 0644) err := os.WriteFile(fname, []byte("Bar"), 0644)
check("WriteFile", err) check("WriteFile", err)
defer os.Remove(dname)
defer os.Remove(fname) defer os.Remove(fname)
tr := &Transport{} tr := &Transport{}

6
src/net/http/fs_test.go
View file

@ -378,11 +378,7 @@ func mustRemoveAll(dir string) {
func TestFileServerImplicitLeadingSlash(t *testing.T) { func TestFileServerImplicitLeadingSlash(t *testing.T) {
defer afterTest(t) defer afterTest(t)
tempDir, err := os.MkdirTemp("", "") tempDir := t.TempDir()
if err != nil {
t.Fatalf("TempDir: %v", err)
}
defer mustRemoveAll(tempDir)
if err := os.WriteFile(filepath.Join(tempDir, "foo.txt"), []byte("Hello world"), 0644); err != nil { if err := os.WriteFile(filepath.Join(tempDir, "foo.txt"), []byte("Hello world"), 0644); err != nil {
t.Fatalf("WriteFile: %v", err) t.Fatalf("WriteFile: %v", err)
} }