Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/link: mangle certain instantiated function name in plugin mode

Browse source 
In plugin mode, we mangle the type symbol name so it doesn't
contain characters that may confuse the external linker. With
generics, instantiated function name includes type names, so it
may also contain such characters and so also needs to be mangled.

Fixes #58800.

Change-Id: Ibb08c95b89b8a815ccef98193d3a025e9d4756cc
Reviewed-on: https://go-review.googlesource.com/c/go/+/500095
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
This commit is contained in:
Cherry Mui 2023-06-01 17:35:28 -04:00
parent 6801c27837
commit 5e9b76fe2a
3 changed files with 47 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/cmd/link/internal/ld/lib.go
View file

@ -984,7 +984,9 @@ func (ctxt *Link) mangleTypeSym() {
// Leave type:runtime. symbols alone, because other parts of
// the linker manipulates them.
func typeSymbolMangle(name string) string {
if !strings.HasPrefix(name, "type:") {
isType := strings.HasPrefix(name, "type:")
if !isType && !strings.Contains(name, "@") {
// Issue 58800: instantiated symbols may include a type name, which may contain "@"
return name
}
if strings.HasPrefix(name, "type:runtime.") {
@ -993,12 +995,22 @@ func typeSymbolMangle(name string) string {
if len(name) <= 14 && !strings.Contains(name, "@") { // Issue 19529
return name
}
hash := notsha256.Sum256([]byte(name))
prefix := "type:"
if name[5] == '.' {
prefix = "type:."
if isType {
hash := notsha256.Sum256([]byte(name[5:]))
prefix := "type:"
if name[5] == '.' {
prefix = "type:."
}
return prefix + base64.StdEncoding.EncodeToString(hash[:6])
}
return prefix + base64.StdEncoding.EncodeToString(hash[:6])
// instantiated symbol, replace type name in []
i := strings.IndexByte(name, '[')
j := strings.LastIndexByte(name, ']')
if j == -1 {
j = len(name)
}
hash := notsha256.Sum256([]byte(name[i+1 : j]))
return name[:i+1] + base64.StdEncoding.EncodeToString(hash[:6]) + name[j:]
}
/*