Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: cross-reference _func type better

Browse source 
It takes me several minutes every time I want to find where the linker
writes out the _func structures. Add some comments to make this
easier.

Change-Id: Ic75ce2786ca4b25726babe3c4fe9cd30c85c34e2
Reviewed-on: https://go-review.googlesource.com/34390
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Austin Clements 2016-12-14 13:24:21 -05:00
parent 1716add3dc
commit 61db2e4efa
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/cmd/link/internal/ld/pcln.go
View file

@ -248,6 +248,9 @@ func (ctxt *Link) pclntab() {
setaddr(ctxt, ftab, 8+int64(SysArch.PtrSize)+int64(nfunc)*2*int64(SysArch.PtrSize), s) setaddr(ctxt, ftab, 8+int64(SysArch.PtrSize)+int64(nfunc)*2*int64(SysArch.PtrSize), s)
setuintxx(ctxt, ftab, 8+int64(SysArch.PtrSize)+int64(nfunc)*2*int64(SysArch.PtrSize)+int64(SysArch.PtrSize), uint64(funcstart), int64(SysArch.PtrSize)) setuintxx(ctxt, ftab, 8+int64(SysArch.PtrSize)+int64(nfunc)*2*int64(SysArch.PtrSize)+int64(SysArch.PtrSize), uint64(funcstart), int64(SysArch.PtrSize))
// Write runtime._func. Keep in sync with ../../../../runtime/runtime2.go:/_func
// and package debug/gosym.
// fixed size of struct, checked below // fixed size of struct, checked below
off := funcstart off := funcstart

2
src/runtime/runtime2.go
View file

@ -615,7 +615,7 @@ const (
// Layout of in-memory per-function information prepared by linker // Layout of in-memory per-function information prepared by linker
// See https://golang.org/s/go12symtab. // See https://golang.org/s/go12symtab.
// Keep in sync with linker // Keep in sync with linker (../cmd/link/internal/ld/pcln.go:/pclntab)
// and with package debug/gosym and with symtab.go in package runtime. // and with package debug/gosym and with symtab.go in package runtime.
type _func struct { type _func struct {
entry uintptr // start pc entry uintptr // start pc