Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile/internal/types: don't export Nopkg anymore

Browse source 
There's already special code to access it.

Change-Id: I28ca4f44a04262407ee9f1c826ada4e7eba44775
Reviewed-on: https://go-review.googlesource.com/41073
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Robert Griesemer 2017-04-19 10:36:31 -07:00
parent b2a363b7ea
commit 62a2bee7a5
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/compile/internal/gc/reflect.go
View file

@ -90,7 +90,7 @@ func uncommonSize(t *types.Type) int { // Sizeof(runtime.uncommontype{})
func makefield(name string, t *types.Type) *types.Field { func makefield(name string, t *types.Type) *types.Field {
f := types.NewField() f := types.NewField()
f.Type = t f.Type = t
f.Sym = types.Nopkg.Lookup(name) f.Sym = (*types.Pkg)(nil).Lookup(name)
return f return f
} }

8
src/cmd/compile/internal/types/pkg.go
View file

@ -45,7 +45,7 @@ func NewPkg(path, name string) *Pkg {
return p return p
} }
var Nopkg = &Pkg{ var nopkg = &Pkg{
Syms: make(map[string]*Sym), Syms: make(map[string]*Sym),
} }
@ -58,8 +58,9 @@ var InitSyms []*Sym
// LookupOK looks up name in pkg and reports whether it previously existed. // LookupOK looks up name in pkg and reports whether it previously existed.
func (pkg *Pkg) LookupOK(name string) (s *Sym, existed bool) { func (pkg *Pkg) LookupOK(name string) (s *Sym, existed bool) {
// TODO(gri) remove this check in favor of specialized lookup
if pkg == nil { if pkg == nil {
pkg = Nopkg pkg = nopkg
} }
if s := pkg.Syms[name]; s != nil { if s := pkg.Syms[name]; s != nil {
return s, true return s, true
@ -77,8 +78,9 @@ func (pkg *Pkg) LookupOK(name string) (s *Sym, existed bool) {
} }
func (pkg *Pkg) LookupBytes(name []byte) *Sym { func (pkg *Pkg) LookupBytes(name []byte) *Sym {
// TODO(gri) remove this check in favor of specialized lookup
if pkg == nil { if pkg == nil {
pkg = Nopkg pkg = nopkg
} }
if s := pkg.Syms[string(name)]; s != nil { if s := pkg.Syms[string(name)]; s != nil {
return s return s