Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: use correct store types in softfloat

Browse source 
When using softfloat, floating point ops are rewritten to integer
ops. The types of store ops were not rewritten. This may lower
to floating point stores, which are problematic. This CL fixes
this by rewriting the store types as well.

This fixes test/fixedbugs/issue28688.go on Wasm. Softfloat mode
is not used by default on Wasm, and it is not needed as Wasm spec
supports floating points. But it is nice to have the correct
types.

Change-Id: Ib5e19e19fa9491b15c2f60320f8724cace5cefb5
Reviewed-on: https://go-review.googlesource.com/c/149965
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Cherry Zhang 2018-11-16 22:53:04 -05:00
parent 649b89377e
commit 63a3993a33
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/cmd/compile/internal/ssa/softfloat.go
View file

@ -4,7 +4,10 @@
package ssa
import "math"
import (
"cmd/compile/internal/types"
"math"
)
func softfloat(f *Func) {
if !f.Config.SoftFloat {
@ -53,6 +56,15 @@ func softfloat(f *Func) {
v.Type = f.Config.Types.UInt64
}
newInt64 = newInt64 || v.Type.Size() == 8
} else if (v.Op == OpStore || v.Op == OpZero || v.Op == OpMove) && v.Aux.(*types.Type).IsFloat() {
switch size := v.Aux.(*types.Type).Size(); size {
case 4:
v.Aux = f.Config.Types.UInt32
case 8:
v.Aux = f.Config.Types.UInt64
default:
v.Fatalf("bad float type with size %d", size)
}
}
}
}