Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

introduce os.EOF and io.ErrUnexpectedEOF.

Browse source 
remove io.ErrEOF.
rename io.FullRead to io.ReadFull, to match
   ReadAtLeast and ReadAll.
remove io.FullReader, because it is now unused.

R=r
DELTA=295  (88 added, 105 deleted, 102 changed)
OCL=30544
CL=30588
This commit is contained in:
Russ Cox 2009-06-22 13:26:13 -07:00
parent 022ee0c26f
commit 64684cc2a2
23 changed files with 147 additions and 164 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/pkg/exec/exec_test.go
View file

@ -18,16 +18,15 @@ func TestRunCat(t *testing.T) {
}
io.WriteString(cmd.Stdin, "hello, world\n");
cmd.Stdin.Close();
var buf [64]byte;
n, err1 := io.FullRead(cmd.Stdout, &buf);
if err1 != nil && err1 != io.ErrEOF {
t.Fatalf("reading from /bin/cat: %v", err1);
buf, err := io.ReadAll(cmd.Stdout);
if err != nil {
t.Fatalf("reading from /bin/cat: %v", err);
}
if string(buf[0:n]) != "hello, world\n" {
t.Fatalf("reading from /bin/cat: got %q", buf[0:n]);
if string(buf) != "hello, world\n" {
t.Fatalf("reading from /bin/cat: got %q", buf);
}
if err1 = cmd.Close(); err1 != nil {
t.Fatalf("closing /bin/cat: %v", err1);
if err = cmd.Close(); err != nil {
t.Fatalf("closing /bin/cat: %v", err);
}
}
@ -37,15 +36,14 @@ func TestRunEcho(t *testing.T) {
if err != nil {
t.Fatalf("opencmd /bin/echo: %v", err);
}
var buf [64]byte;
n, err1 := io.FullRead(cmd.Stdout, &buf);
if err1 != nil && err1 != io.ErrEOF {
t.Fatalf("reading from /bin/echo: %v", err1);
buf, err := io.ReadAll(cmd.Stdout);
if err != nil {
t.Fatalf("reading from /bin/echo: %v", err);
}
if string(buf[0:n]) != "hello world\n" {
t.Fatalf("reading from /bin/echo: got %q", buf[0:n]);
if string(buf) != "hello world\n" {
t.Fatalf("reading from /bin/echo: got %q", buf);
}
if err1 = cmd.Close(); err1 != nil {
t.Fatalf("closing /bin/echo: %v", err1);
if err = cmd.Close(); err != nil {
t.Fatalf("closing /bin/echo: %v", err);
}
}