Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: properly frame panic values in tracebacks

Browse source 
This CL causes the printing of panic values to ensure that all
newlines in the output are immediately followed by a tab, so
that there is no way for a maliciously crafted panic value to
fool a program attempting to parse the traceback into thinking
that the panic value is in fact a goroutine stack.

See https://github.com/golang/go/issues/64590#issuecomment-1932675696

+ release note

Updates #64590
Updates #63455

Change-Id: I5142acb777383c0c122779d984e73879567dc627
Reviewed-on: https://go-review.googlesource.com/c/go/+/581215
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
This commit is contained in:
Alan Donovan 2024-04-23 12:44:54 -04:00 • committed by Gopher Robot
parent 4513f1a1c1
commit 69e75c8581
8 changed files with 56 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/runtime/crash_test.go
View file

@ -966,11 +966,11 @@ func TestPanicWhilePanicking(t *testing.T) {
Func string
}{
{
"panic while printing panic value: important error message",
"panic while printing panic value: important multi-line\n\terror message",
"ErrorPanic",
},
{
"panic while printing panic value: important stringer message",
"panic while printing panic value: important multi-line\n\tstringer message",
"StringerPanic",
},
{
@ -986,7 +986,7 @@ func TestPanicWhilePanicking(t *testing.T) {
"CircularPanic",
},
{
"important string message",
"important multi-line\n\tstring message",
"StringPanic",
},
{