Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

all: use t.Skip{,f}

Browse source 
Replace various t.Log{,f} ; return checks with t.Skip{,f}.

R=golang-dev, n13m3y3r, bradfitz, adg, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/7193044
This commit is contained in:
Dave Cheney 2013-01-24 17:32:10 +11:00
parent 2e51f78280
commit 6a9e956f19
31 changed files with 126 additions and 256 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/pkg/net/dial_test.go
View file

@ -74,8 +74,7 @@ func TestDialTimeout(t *testing.T) {
// by default. FreeBSD likely works, but is untested.
// TODO(rsc):
// The timeout never happens on Windows. Why? Issue 3016.
t.Logf("skipping test on %q; untested.", runtime.GOOS)
return
t.Skipf("skipping test on %q; untested.", runtime.GOOS)
}
connected := 0
@ -107,8 +106,7 @@ func TestDialTimeout(t *testing.T) {
func TestSelfConnect(t *testing.T) {
if runtime.GOOS == "windows" {
// TODO(brainman): do not know why it hangs.
t.Logf("skipping known-broken test on windows")
return
t.Skip("skipping known-broken test on windows")
}
// Test that Dial does not honor self-connects.
// See the comment in DialTCP.
@ -228,8 +226,7 @@ func TestDialError(t *testing.T) {
func TestDialTimeoutFDLeak(t *testing.T) {
if runtime.GOOS != "linux" {
// TODO(bradfitz): test on other platforms
t.Logf("skipping test on %s", runtime.GOOS)
return
t.Skipf("skipping test on %q", runtime.GOOS)
}
ln := newLocalListener(t)