Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

compress/gzip: always close bodyReader in Example_compressingReader

Browse source 
For #53362
Fixes #53414

Change-Id: I352164e70c136eed210c7ee4ceba5dc631f81f94
Reviewed-on: https://go-review.googlesource.com/c/go/+/412955
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Joseph Tsai <joetsai@digital-static.net>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Ian Lance Taylor 2022-06-17 13:38:07 -07:00 • committed by Gopher Robot
parent 606c6c371a
commit 6bad7e8243
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/compress/gzip/example_test.go
View file

@ -160,6 +160,10 @@ func Example_compressingReader() {
// httpWriter is the body of the HTTP request, as an io.Writer. // httpWriter is the body of the HTTP request, as an io.Writer.
bodyReader, httpWriter := io.Pipe() bodyReader, httpWriter := io.Pipe()
// Make sure that bodyReader is always closed, so that the
// goroutine below will always exit.
defer bodyReader.Close()
// gzipWriter compresses data to httpWriter. // gzipWriter compresses data to httpWriter.
gzipWriter := gzip.NewWriter(httpWriter) gzipWriter := gzip.NewWriter(httpWriter)
@ -197,7 +201,6 @@ func Example_compressingReader() {
// Note that passing req to http.Client.Do promises that it // Note that passing req to http.Client.Do promises that it
// will close the body, in this case bodyReader. // will close the body, in this case bodyReader.
// That ensures that the goroutine will exit.
resp, err := ts.Client().Do(req) resp, err := ts.Client().Do(req)
if err != nil { if err != nil {
log.Fatal(err) log.Fatal(err)