Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: mention issue 28603 when discussing where inline marks go

Browse source 
Update #28603

Change-Id: I8bdbea57b3661e15dcc760d27252b794daa476db
Reviewed-on: https://go-review.googlesource.com/c/go/+/177697
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
This commit is contained in:
Keith Randall 2019-05-16 16:16:26 -07:00 • committed by Keith Randall
parent 97ecc4321e
commit 6c842cc610
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/cmd/compile/internal/gc/inl.go
View file

@ -1046,10 +1046,11 @@ func mkinlcall(n, fn *Node, maxCost int32) *Node {
} }
newIndex := Ctxt.InlTree.Add(parent, n.Pos, fn.Sym.Linksym()) newIndex := Ctxt.InlTree.Add(parent, n.Pos, fn.Sym.Linksym())
// Add a inline mark just before the inlined body. // Add an inline mark just before the inlined body.
// This mark is inline in the code so that it's a reasonable spot // This mark is inline in the code so that it's a reasonable spot
// to put a breakpoint. Not sure if that's really necessary or not // to put a breakpoint. Not sure if that's really necessary or not
// (in which case it could go at the end of the function instead). // (in which case it could go at the end of the function instead).
// Note issue 28603.
inlMark := nod(OINLMARK, nil, nil) inlMark := nod(OINLMARK, nil, nil)
inlMark.Pos = n.Pos.WithIsStmt() inlMark.Pos = n.Pos.WithIsStmt()
inlMark.Xoffset = int64(newIndex) inlMark.Xoffset = int64(newIndex)