Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

runtime: revert recent Windows crashdump changes

Browse source 
Recent changes to runtime enabled crashdumps, which under some
circumstances apparently might result in memory being uploaded to
Microsoft. A change like this should go through the proper proposals
process where we can discuss how to gate it and what all of its
implications are.

This reverts CL 307372 and its cleanup CL 360617.

Change-Id: If2e74015899d746831da40546c82eacacdf739e1
Reviewed-on: https://go-review.googlesource.com/c/go/+/362454
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Jason A. Donenfeld 2021-11-09 01:23:02 +01:00
parent 5344dcae41
commit 6dcf83d882
3 changed files with 22 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/runtime/panic.go
View file

@ -1002,11 +1002,6 @@ var runningPanicDefers uint32
// panicking is incremented and decremented atomically.
var panicking uint32
// tracebackprinted is zero before gopanic() prints the traceback. After
// traceback is printed, it sets to 1 so that the subsequent exception handler
// won't print the traceback again.
var tracebackprinted uint32
// paniclk is held while printing the panic information and stack trace,
// so that two concurrent panics don't overlap their output.
var paniclk mutex
@ -1050,9 +1045,6 @@ func fatalthrow() {
startpanic_m()
if dopanic_m(gp, pc, sp) {
// At this point, traceback has already been printed.
// Set tracebackprinted to 1 to avoid printing traceback again
tracebackprinted = 1
// crash uses a decent amount of nosplit stack and we're already
// low on stack in throw, so crash on the system stack (unlike
// fatalpanic).
@ -1094,9 +1086,6 @@ func fatalpanic(msgs *_panic) {
})
if docrash {
// At this point, traceback has already been printed.
// Set tracebackprinted to 1 to avoid printing traceback again
tracebackprinted = 1
// By crashing outside the above systemstack call, debuggers
// will not be confused when generating a backtrace.
// Function crash is marked nosplit to avoid stack growth.