Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: remove no-longer-necessary call to calculateDepths

Browse source 
We now calculate depths by default, no need to ask.
All calls were removed in CL 680775 when that CL was written, but an
additional call appeared between then and submitting the CL. Oops.

Another case for which a presubmit check would help.

Fixes #74762

Change-Id: I1b70ed7f91b56e4939b4a3d0ad7a5f31fe396b4c
Reviewed-on: https://go-review.googlesource.com/c/go/+/690036
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: t hepudds <thepudds1460@gmail.com>
This commit is contained in:
Keith Randall 2025-07-25 14:15:50 -07:00 • committed by Gopher Robot
parent 5045fdd8ff
commit 6fbad4be75
2 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/compile/internal/ssa/likelyadjust.go
View file

@ -15,7 +15,7 @@ type loop struct {
// Next three fields used by regalloc and/or // Next three fields used by regalloc and/or
// aid in computation of inner-ness and list of blocks. // aid in computation of inner-ness and list of blocks.
nBlocks int32 // Number of blocks in this loop but not within inner loops nBlocks int32 // Number of blocks in this loop but not within inner loops
depth int16 // Nesting depth of the loop; 1 is outermost. Initialized by calculateDepths(). depth int16 // Nesting depth of the loop; 1 is outermost.
isInner bool // True if never discovered to contain a loop isInner bool // True if never discovered to contain a loop
// True if all paths through the loop have a call. // True if all paths through the loop have a call.

1
src/cmd/compile/internal/ssa/looprotate.go
View file

@ -82,7 +82,6 @@ func loopRotate(f *Func) {
// Order loops to rotate any child loop before adding its top block // Order loops to rotate any child loop before adding its top block
// to the parent loop's 'after' list. // to the parent loop's 'after' list.
loopnest.calculateDepths()
loopOrder := f.Cache.allocIntSlice(len(loopnest.loops)) loopOrder := f.Cache.allocIntSlice(len(loopnest.loops))
for i := range loopOrder { for i := range loopOrder {
loopOrder[i] = i loopOrder[i] = i