Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

sql: fix potential corruption in QueryRow.Scan into a *[]byte

Browse source 
Fixes #2622

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5533077
This commit is contained in:
Brad Fitzpatrick 2012-01-12 11:23:33 -08:00
parent c356fc74a1
commit 701f70abf6
3 changed files with 66 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/pkg/exp/sql/sql_test.go
View file

@ -21,10 +21,10 @@ func newTestDB(t *testing.T, name string) *DB {
t.Fatalf("exec wipe: %v", err)
}
if name == "people" {
exec(t, db, "CREATE|people|name=string,age=int32,dead=bool")
exec(t, db, "INSERT|people|name=Alice,age=?", 1)
exec(t, db, "INSERT|people|name=Bob,age=?", 2)
exec(t, db, "INSERT|people|name=Chris,age=?", 3)
exec(t, db, "CREATE|people|name=string,age=int32,photo=blob,dead=bool")
exec(t, db, "INSERT|people|name=Alice,age=?,photo=APHOTO", 1)
exec(t, db, "INSERT|people|name=Bob,age=?,photo=BPHOTO", 2)
exec(t, db, "INSERT|people|name=Chris,age=?,photo=CPHOTO", 3)
}
return db
}
@ -132,6 +132,16 @@ func TestQueryRow(t *testing.T) {
if age != 1 {
t.Errorf("expected age 1, got %d", age)
}
var photo []byte
err = db.QueryRow("SELECT|people|photo|name=?", "Alice").Scan(&photo)
if err != nil {
t.Fatalf("photo QueryRow+Scan: %v", err)
}
want := []byte("APHOTO")
if !reflect.DeepEqual(photo, want) {
t.Errorf("photo = %q; want %q", photo, want)
}
}
func TestStatementErrorAfterClose(t *testing.T) {