Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-11-01 01:00:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

all: use time.Time.Equal instead of == in some tests

Browse source 
(Found by making time.Time uncomparable and rerunning std tests
locally.)

Change-Id: I4fa6fb0ba7334965362387e2f6541c17a27ac3aa
Reviewed-on: https://go-review.googlesource.com/42616
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Brad Fitzpatrick 2017-05-04 15:05:33 +00:00
parent b8c7fddd58
commit 71e63fa44f
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/go/go_test.go
View file

@ -3090,7 +3090,7 @@ func TestGoTestRaceInstallCgo(t *testing.T) {
tg.run("test", "-race", "-i", "runtime/race") tg.run("test", "-race", "-i", "runtime/race")
new, err := os.Stat(cgo) new, err := os.Stat(cgo)
tg.must(err) tg.must(err)
if new.ModTime() != old.ModTime() { if !new.ModTime().Equal(old.ModTime()) {
t.Fatalf("go test -i runtime/race reinstalled cmd/cgo") t.Fatalf("go test -i runtime/race reinstalled cmd/cgo")
} }
} }

2
src/net/dial_test.go
View file

@ -529,7 +529,7 @@ func TestDialerPartialDeadline(t *testing.T) {
if err != tt.expectErr { if err != tt.expectErr {
t.Errorf("#%d: got %v; want %v", i, err, tt.expectErr) t.Errorf("#%d: got %v; want %v", i, err, tt.expectErr)
} }
if deadline != tt.expectDeadline { if !deadline.Equal(tt.expectDeadline) {
t.Errorf("#%d: got %v; want %v", i, deadline, tt.expectDeadline) t.Errorf("#%d: got %v; want %v", i, deadline, tt.expectDeadline)
} }
} }

2
src/net/dnsclient_unix_test.go
View file

@ -784,7 +784,7 @@ func TestRetryTimeout(t *testing.T) {
return nil, poll.ErrTimeout return nil, poll.ErrTimeout
} }
if deadline == deadline0 { if deadline.Equal(deadline0) {
t.Error("deadline didn't change") t.Error("deadline didn't change")
} }