Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: free value earlier in nilcheck

Browse source 
When we remove a nil check, add it back to the free Value pool immediately.

Fixes #18732

Change-Id: I8d644faabbfb52157d3f2d071150ff0342ac28dc
Reviewed-on: https://go-review.googlesource.com/58810
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
This commit is contained in:
Keith Randall 2017-08-24 16:11:44 -07:00
parent 3723d08022
commit 770d8d8207
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/cmd/compile/internal/ssa/func.go
View file

@ -175,7 +175,7 @@ func (f *Func) LogStat(key string, args ...interface{}) {
f.Warnl(f.Entry.Pos, "\t%s\t%s%s\t%s", n, key, value, f.Name)
}
// freeValue frees a value. It must no longer be referenced.
// freeValue frees a value. It must no longer be referenced or have any args.
func (f *Func) freeValue(v *Value) {
if v.Block == nil {
f.Fatalf("trying to free an already freed value")
@ -183,6 +183,9 @@ func (f *Func) freeValue(v *Value) {
if v.Uses != 0 {
f.Fatalf("value %s still has %d uses", v, v.Uses)
}
if len(v.Args) != 0 {
f.Fatalf("value %s still has %d args", v, len(v.Args))
}
// Clear everything but ID (which we reuse).
id := v.ID