Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

reflect: make Index and Slice accept strings

Browse source 
Fixes #3284.

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/6643043
This commit is contained in:
Evan Shaw 2012-10-21 17:02:10 -04:00 • committed by Russ Cox
parent d7a3407e3d
commit 772decbc80
2 changed files with 49 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/pkg/reflect/all_test.go
View file

@ -2036,6 +2036,24 @@ func TestSmallNegativeInt(t *testing.T) {
}
}
func TestIndex(t *testing.T) {
xs := []byte{1, 2, 3, 4, 5, 6, 7, 8}
v := ValueOf(xs).Index(3).Interface().(byte)
if v != xs[3] {
t.Errorf("xs.Index(3) = %v; expected %v", v, xs[3])
}
xa := [8]byte{10, 20, 30, 40, 50, 60, 70, 80}
v = ValueOf(xa).Index(2).Interface().(byte)
if v != xa[2] {
t.Errorf("xa.Index(2) = %v; expected %v", v, xa[2])
}
s := "0123456789"
v = ValueOf(s).Index(3).Interface().(byte)
if v != s[3] {
t.Errorf("s.Index(3) = %v; expected %v", v, s[3])
}
}
func TestSlice(t *testing.T) {
xs := []int{1, 2, 3, 4, 5, 6, 7, 8}
v := ValueOf(xs).Slice(3, 5).Interface().([]int)
@ -2048,7 +2066,6 @@ func TestSlice(t *testing.T) {
if !DeepEqual(v[0:5], xs[3:]) {
t.Errorf("xs.Slice(3, 5)[0:5] = %v", v[0:5])
}
xa := [8]int{10, 20, 30, 40, 50, 60, 70, 80}
v = ValueOf(&xa).Elem().Slice(2, 5).Interface().([]int)
if len(v) != 3 {
@ -2060,6 +2077,11 @@ func TestSlice(t *testing.T) {
if !DeepEqual(v[0:6], xa[2:]) {
t.Errorf("xs.Slice(2, 5)[0:6] = %v", v[0:6])
}
s := "0123456789"
vs := ValueOf(s).Slice(3, 5).Interface().(string)
if vs != s[3:5] {
t.Errorf("s.Slice(3, 5) = %q; expected %q", vs, s[3:5])
}
}
func TestVariadic(t *testing.T) {