Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.simd] cmd/compile: flip sense of intrinsics test for SIMD

Browse source 
ENABLE when simd experiment is off, to be sure intrinsics
do not leak past the experiment.

DISABLE when simd is on, because all this does is cause tests to
fail, then whoever failed the test regenerates the simd, doesn't look
at the mountain of new intrinsics, and just rubber-stamps the change.
All friction, no benefit.

Change-Id: I2ef7e0c246aaddd4a52c1d6108cb587adc1b8366
Reviewed-on: https://go-review.googlesource.com/c/go/+/677555
Auto-Submit: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
David Chase 2025-05-30 11:39:02 -04:00 • committed by Gopher Robot
parent eba2430c16
commit 7800f3813c
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/cmd/compile/internal/ssagen/intrinsics_test.go
View file

@ -16,7 +16,10 @@ import (
) )
var updateIntrinsics = flag.Bool("update", false, "Print an updated intrinsics table") var updateIntrinsics = flag.Bool("update", false, "Print an updated intrinsics table")
var simd = flag.Bool("simd", buildcfg.Experiment.SIMD, "Also check SIMD intrinsics; defaults to GOEXPERIMENT==simd")
// TODO turn on always. Current setting insures that simd intrinsics do not leak past experiment,
// but also avoids fail+rubber-stamp-update friction while SIMD is under active development.
var simd = flag.Bool("simd", !buildcfg.Experiment.SIMD, "Also check SIMD intrinsics; default to GOEXPERIMENT = NO simd")
type testIntrinsicKey struct { type testIntrinsicKey struct {
archName string archName string