Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

net: make protocol-specific WriteTo, WriteMsg methods return error instead of crash

Browse source 
R=golang-dev, dave, rsc, adg, bradfitz
CC=golang-dev
https://golang.org/cl/11809043
This commit is contained in:
Mikio Hara 2013-08-18 19:19:36 +09:00
parent df7b93c175
commit 7917b88a06
5 changed files with 47 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/pkg/net/protoconn_test.go
View file

@ -161,6 +161,15 @@ func TestUDPConnSpecificMethods(t *testing.T) {
} else {
f.Close()
}
defer func() {
if p := recover(); p != nil {
t.Fatalf("UDPConn.WriteToUDP or WriteMsgUDP panicked: %v", p)
}
}()
c.WriteToUDP(wb, nil)
c.WriteMsgUDP(wb, nil, nil)
}
func TestIPConnSpecificMethods(t *testing.T) {
@ -218,6 +227,15 @@ func TestIPConnSpecificMethods(t *testing.T) {
} else {
f.Close()
}
defer func() {
if p := recover(); p != nil {
t.Fatalf("IPConn.WriteToIP or WriteMsgIP panicked: %v", p)
}
}()
c.WriteToIP(wb, nil)
c.WriteMsgIP(wb, nil, nil)
}
func TestUnixListenerSpecificMethods(t *testing.T) {
@ -358,4 +376,15 @@ func TestUnixConnSpecificMethods(t *testing.T) {
} else {
f.Close()
}
defer func() {
if p := recover(); p != nil {
t.Fatalf("UnixConn.WriteToUnix or WriteMsgUnix panicked: %v", p)
}
}()
c1.WriteToUnix(wb, nil)
c1.WriteMsgUnix(wb, nil, nil)
c3.WriteToUnix(wb, nil)
c3.WriteMsgUnix(wb, nil, nil)
}