mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
testing: don't be silent if a test's goroutine fails a test after test exits
Fixes #15654 Change-Id: I9bdaa9b76d480d75f24d95f0235efd4a79e3593e Reviewed-on: https://go-review.googlesource.com/23320 Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: Marcel van Lohuizen <mpvl@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
This commit is contained in:
parent
dcc42c7d11
commit
7b9d3ff4cb
2 changed files with 31 additions and 2 deletions
|
|
@ -307,6 +307,27 @@ func TestTRun(t *T) {
|
|||
f: func(t *T) {
|
||||
t.Skip()
|
||||
},
|
||||
}, {
|
||||
desc: "panic on goroutine fail after test exit",
|
||||
ok: false,
|
||||
maxPar: 4,
|
||||
f: func(t *T) {
|
||||
ch := make(chan bool)
|
||||
t.Run("", func(t *T) {
|
||||
go func() {
|
||||
<-ch
|
||||
defer func() {
|
||||
if r := recover(); r == nil {
|
||||
realTest.Errorf("expected panic")
|
||||
}
|
||||
ch <- true
|
||||
}()
|
||||
t.Errorf("failed after success")
|
||||
}()
|
||||
})
|
||||
ch <- true
|
||||
<-ch
|
||||
},
|
||||
}}
|
||||
for _, tc := range testCases {
|
||||
ctx := newTestContext(tc.maxPar, newMatcher(regexp.MatchString, "", ""))
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue