mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
runtime: write much more direct test for semaphore waiter scalability
This test originally existed as two tests in test/locklinear.go, but this checked against actual locks and was flaky. The test was checking a property of a deep part of the runtime but from a much higher level, and it's easy for nondeterminism due to scheduling to completely mess that up, especially on an oversubscribed system. That test was then moved to the sync package with a more rigorous testing methodology, but it could still flake pretty easily. Finally, this CL makes semtable more testable, exports it in export_test.go, then writes a very direct scalability test for exactly the situation the original test described. As far as I can tell, this is much, much more stable, because it's single-threaded and is just checking exactly the algorithm we need to check. Don't bother trying to bring in a test that checks for O(log n) behavior on the other kind of iteration. It'll be perpetually flaky because the underlying data structure is a treap, so it's only _expected_ to be O(log n), but it's very easy for it to get unlucky without a large number of iterations that's too much for a simple test. Fixes #53381. Change-Id: Ia1cd2d2b0e36d552d5a8ae137077260a16016602 Reviewed-on: https://go-review.googlesource.com/c/go/+/412875 Reviewed-by: Michael Pratt <mpratt@google.com>
This commit is contained in:
parent
f38a580a51
commit
7bad61554e
4 changed files with 83 additions and 121 deletions
|
|
@ -1163,10 +1163,38 @@ var Semacquire = semacquire
|
|||
var Semrelease1 = semrelease1
|
||||
|
||||
func SemNwait(addr *uint32) uint32 {
|
||||
root := semroot(addr)
|
||||
root := semtable.rootFor(addr)
|
||||
return atomic.Load(&root.nwait)
|
||||
}
|
||||
|
||||
const SemTableSize = semTabSize
|
||||
|
||||
// SemTable is a wrapper around semTable exported for testing.
|
||||
type SemTable struct {
|
||||
semTable
|
||||
}
|
||||
|
||||
// Enqueue simulates enqueuing a waiter for a semaphore (or lock) at addr.
|
||||
func (t *SemTable) Enqueue(addr *uint32) {
|
||||
s := acquireSudog()
|
||||
s.releasetime = 0
|
||||
s.acquiretime = 0
|
||||
s.ticket = 0
|
||||
t.semTable.rootFor(addr).queue(addr, s, false)
|
||||
}
|
||||
|
||||
// Dequeue simulates dequeuing a waiter for a semaphore (or lock) at addr.
|
||||
//
|
||||
// Returns true if there actually was a waiter to be dequeued.
|
||||
func (t *SemTable) Dequeue(addr *uint32) bool {
|
||||
s, _ := t.semTable.rootFor(addr).dequeue(addr)
|
||||
if s != nil {
|
||||
releaseSudog(s)
|
||||
return true
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// mspan wrapper for testing.
|
||||
//
|
||||
//go:notinheap
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue