mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
cmd/compile: add -d=checkptr to validate unsafe.Pointer rules
This CL adds -d=checkptr as a compile-time option for adding instrumentation to check that Go code is following unsafe.Pointer safety rules dynamically. In particular, it currently checks two things: 1. When converting unsafe.Pointer to *T, make sure the resulting pointer is aligned appropriately for T. 2. When performing pointer arithmetic, if the result points to a Go heap object, make sure we can find an unsafe.Pointer-typed operand that pointed into the same object. These checks are currently disabled for the runtime, and can also be disabled through a new //go:nocheckptr annotation. The latter is necessary for functions like strings.noescape, which intentionally violate safety rules to workaround escape analysis limitations. Fixes #22218. Change-Id: If5a51273881d93048f74bcff10a3275c9c91da6a Reviewed-on: https://go-review.googlesource.com/c/go/+/162237 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
parent
3b003c3edb
commit
80a6fedea0
9 changed files with 159 additions and 1 deletions
|
|
@ -1407,6 +1407,11 @@ func (v Value) OverflowUint(x uint64) bool {
|
|||
panic(&ValueError{"reflect.Value.OverflowUint", v.kind()})
|
||||
}
|
||||
|
||||
//go:nocheckptr
|
||||
// This prevents inlining Value.Pointer when -d=checkptr is enabled,
|
||||
// which ensures cmd/compile can recognize unsafe.Pointer(v.Pointer())
|
||||
// and make an exception.
|
||||
|
||||
// Pointer returns v's value as a uintptr.
|
||||
// It returns uintptr instead of unsafe.Pointer so that
|
||||
// code using reflect cannot obtain unsafe.Pointers
|
||||
|
|
@ -1914,6 +1919,11 @@ func (v Value) Uint() uint64 {
|
|||
panic(&ValueError{"reflect.Value.Uint", v.kind()})
|
||||
}
|
||||
|
||||
//go:nocheckptr
|
||||
// This prevents inlining Value.UnsafeAddr when -d=checkptr is enabled,
|
||||
// which ensures cmd/compile can recognize unsafe.Pointer(v.UnsafeAddr())
|
||||
// and make an exception.
|
||||
|
||||
// UnsafeAddr returns a pointer to v's data.
|
||||
// It is for advanced clients that also import the "unsafe" package.
|
||||
// It panics if v is not addressable.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue