Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-02-06 18:00:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

net/http: deflake TestClientConnReserveAndConsume

Browse source 
This test includes an assertion that a client conn's state hook
is called exactly once, but some of the test cases can result in
two events occurring: A request completes and a connection closes.

Change the assertion to just check that the hook is called
at least once.

Fixes #76480

Change-Id: Ie1438581b072b10623eb3d5fe443294a639c9853
Reviewed-on: https://go-review.googlesource.com/c/go/+/725601
Commit-Queue: Damien Neil <dneil@google.com>
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Nicholas Husin <husin@google.com>
Reviewed-by: Nicholas Husin <nsh@golang.org>
TryBot-Bypass: Damien Neil <dneil@google.com>
This commit is contained in:
Damien Neil 2025-12-01 12:28:19 -08:00
parent 94616dad42
commit 8b5db48db1
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/net/http/clientconn_test.go
View file

@ -286,9 +286,10 @@ func TestClientConnReserveAndConsume(t *testing.T) {
synctest.Wait()
// State hook should be called, either to report the
// connection availability increasing or the connection closing.
if got, want := stateHookCalls, 1; got != want {
t.Errorf("connection state hook calls: %v, want %v", got, want)
// connection availability increasing or the connection closing,
// or both.
if stateHookCalls == 0 {
t.Errorf("connection state hook calls: %v, want >1", stateHookCalls)
}
if test.h1Closed && (mode == http1Mode || mode == https1Mode) {