Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/link: support weak binding on darwin

Browse source 
Symbols loaded from host files can have the N_WEAK_REF bit set,
which is used to instruct the loader to not fail if that symbol
can't be resolved.

The Go internal linker should honor this information by setting the
BIND_SYMBOL_FLAGS_WEAK_IMPORT flag in the corresponding bind table
entry.

Fixes #76023

Cq-Include-Trybots: luci.golang.try:gotip-darwin-amd64-longtest,gotip-darwin-amd64_12,gotip-darwin-arm64_12,gotip-darwin-arm64_15,gotip-darwin-arm64-longtest,gotip-darwin-amd64_14
Change-Id: Id2cef247ec7a9cb08455844f3c30ff874772bb7b
Reviewed-on: https://go-review.googlesource.com/c/go/+/713760
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
qmuntal 2025-10-22 16:33:18 +02:00 • committed by Quim Muntal
parent 2dd7e94e16
commit 8cf7a0b4c9
5 changed files with 62 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/cmd/link/internal/loader/loader.go
View file

@ -241,6 +241,7 @@ type Loader struct {
plt map[Sym]int32 // stores dynimport for pe objects
got map[Sym]int32 // stores got for pe objects
dynid map[Sym]int32 // stores Dynid for symbol
weakBinding map[Sym]bool // stores whether a symbol has a weak binding
relocVariant map[relocId]sym.RelocVariant // stores variant relocs
@ -326,6 +327,7 @@ func NewLoader(flags uint32, reporter *ErrorReporter) *Loader {
plt: make(map[Sym]int32),
got: make(map[Sym]int32),
dynid: make(map[Sym]int32),
weakBinding: make(map[Sym]bool),
attrCgoExportDynamic: make(map[Sym]struct{}),
attrCgoExportStatic: make(map[Sym]struct{}),
deferReturnTramp: make(map[Sym]bool),
@ -1447,6 +1449,18 @@ func (l *Loader) SetSymExtname(i Sym, value string) {
}
}
func (l *Loader) SymWeakBinding(i Sym) bool {
return l.weakBinding[i]
}
func (l *Loader) SetSymWeakBinding(i Sym, v bool) {
// reject bad symbols
if i >= Sym(len(l.objSyms)) || i == 0 {
panic("bad symbol index in SetSymWeakBinding")
}
l.weakBinding[i] = v
}
// SymElfType returns the previously recorded ELF type for a symbol
// (used only for symbols read from shared libraries by ldshlibsyms).
// It is not set for symbols defined by the packages being linked or