mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
runtime: debug code to catch bad gcWork.puts
This adds a debug check to throw immediately if any pointers are added to the gcWork buffer after the mark completion barrier. The intent is to catch the source of the cached GC work that occasionally produces "P has cached GC work at end of mark termination" failures. The result should be that we get "throwOnGCWork" throws instead of "P has cached GC work at end of mark termination" throws, but with useful stack traces. This should be reverted before the release. I've been unable to reproduce this issue locally, but this issue appears fairly regularly on the builders, so the intent is to catch it on the builders. This probably slows down the GC slightly. For #27993. Change-Id: I5035e14058ad313bfbd3d68c41ec05179147a85c Reviewed-on: https://go-review.googlesource.com/c/149969 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
parent
b8fad4b33d
commit
9098d1d854
3 changed files with 31 additions and 2 deletions
|
|
@ -85,7 +85,7 @@ func TestIntendedInlining(t *testing.T) {
|
|||
"puintptr.ptr",
|
||||
"spanOf",
|
||||
"spanOfUnchecked",
|
||||
"(*gcWork).putFast",
|
||||
//"(*gcWork).putFast", // TODO(austin): For debugging #27993
|
||||
"(*gcWork).tryGetFast",
|
||||
"(*guintptr).set",
|
||||
"(*markBits).advance",
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue