mirror of
https://github.com/golang/go.git
synced 2025-10-19 19:13:18 +00:00
strings: don't assert on Replace's allocs for ASAN
CL 657935 caused failures on the ASAN builder.
Under ASAN, do not assert on the number of allocations incurred by Replace.
Fixes #72973
Change-Id: I61536be6def6f2489d2a026c943c6e232865b723
GitHub-Last-Rev: 4aee3c2560
GitHub-Pull-Request: golang/go#72975
Reviewed-on: https://go-review.googlesource.com/c/go/+/659696
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
Auto-Submit: Jorropo <jorropo.pgm@gmail.com>
This commit is contained in:
parent
b613d21ffd
commit
93fe8c0415
1 changed files with 6 additions and 3 deletions
|
@ -7,6 +7,7 @@ package strings_test
|
|||
import (
|
||||
"bytes"
|
||||
"fmt"
|
||||
"internal/asan"
|
||||
"io"
|
||||
"iter"
|
||||
"math"
|
||||
|
@ -1473,10 +1474,12 @@ var ReplaceTests = []struct {
|
|||
|
||||
func TestReplace(t *testing.T) {
|
||||
for _, tt := range ReplaceTests {
|
||||
if !asan.Enabled { // See issue #72973.
|
||||
allocs := testing.AllocsPerRun(10, func() { Replace(tt.in, tt.old, tt.new, tt.n) })
|
||||
if allocs > 1 {
|
||||
t.Errorf("Replace(%q, %q, %q, %d) allocates %.2f objects", tt.in, tt.old, tt.new, tt.n, allocs)
|
||||
}
|
||||
}
|
||||
if s := Replace(tt.in, tt.old, tt.new, tt.n); s != tt.out {
|
||||
t.Errorf("Replace(%q, %q, %q, %d) = %q, want %q", tt.in, tt.old, tt.new, tt.n, s, tt.out)
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue