Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/trace: pprof computation for span types

Browse source 
/spanio, /spanblock, /spansched, /spansyscall provide
the pprof-style summary of span execution's
io, block, scheduling, syscall latency distributions
respectively.

The computation logic for /io, /block, /sched, /syscall
analysis was refactored and extended for reuse in these
new types of analysis. Upon the analysis query, we create
a map of goroutine id to time intervals based on the query
parameter, that represents the interesting time intervals
of matching goroutines. Only the events from the matching
goroutines that fall into the intervals are considered
in the pprof computation.

The new endpoints are not yet hooked into other span
analysis page (e.g. /userspan) yet.

Change-Id: I80c3396e45a2d6631758710de67d132e5832c7ce
Reviewed-on: https://go-review.googlesource.com/105822
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Hana Kim 2018-04-04 14:24:02 -04:00 • committed by Hyang-Ah Hana Kim
parent 8bb8eaff62
commit 95e6a9fc50
2 changed files with 166 additions and 88 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/cmd/trace/main.go
View file

@ -83,19 +83,19 @@ func main() {
flag.Usage()
}
var pprofFunc func(io.Writer, string) error
var pprofFunc func(io.Writer, *http.Request) error
switch *pprofFlag {
case "net":
pprofFunc = pprofIO
pprofFunc = pprofByGoroutine(computePprofIO)
case "sync":
pprofFunc = pprofBlock
pprofFunc = pprofByGoroutine(computePprofBlock)
case "syscall":
pprofFunc = pprofSyscall
pprofFunc = pprofByGoroutine(computePprofSyscall)
case "sched":
pprofFunc = pprofSched
pprofFunc = pprofByGoroutine(computePprofSched)
}
if pprofFunc != nil {
if err := pprofFunc(os.Stdout, ""); err != nil {
if err := pprofFunc(os.Stdout, &http.Request{}); err != nil {
dief("failed to generate pprof: %v\n", err)
}
os.Exit(0)